Skip to content

adding mini hack guide#42

Closed
padmashris wants to merge 22 commits into
fhdsl:mainfrom
BioDataSage:main
Closed

adding mini hack guide#42
padmashris wants to merge 22 commits into
fhdsl:mainfrom
BioDataSage:main

Conversation

@padmashris
Copy link
Copy Markdown
Collaborator

steps to follow through the MAGE Mini Hack added into the last chapter

@avahoffman avahoffman self-requested a review May 12, 2026 16:01
@avahoffman
Copy link
Copy Markdown
Contributor

avahoffman commented May 12, 2026

@padmashris can you make a few changes before I approve the OTTR workflows to run?

  • Remove anything in docs/ or student-guide/ - these are generated automatically via workflow
  • Remove ottr-fy.R

Thanks!!

@padmashris
Copy link
Copy Markdown
Collaborator Author

@avahoffman yes, just removed!

@avahoffman
Copy link
Copy Markdown
Contributor

@padmashris looks like you deleted docs that were already present on main (those should not be deleted, just the ones you made). You should only be changing the following:

Let me know if this doesn't make sense!

@padmashris
Copy link
Copy Markdown
Collaborator Author

@avahoffman got confused sorry, just reverted those so just the 4 changes show up

@avahoffman
Copy link
Copy Markdown
Contributor

Thanks @padmashris ! Currently trying to diagnose the issue with workflow permissions. Should hopefully have a "real" review for you shortly!

@avahoffman
Copy link
Copy Markdown
Contributor

@padmashris I've made a few changes to the pull-request workflow on main. Can you merge those into this branch? Thanks!

merge updates to PR workflow
@padmashris
Copy link
Copy Markdown
Collaborator Author

@avahoffman just merged!

@avahoffman
Copy link
Copy Markdown
Contributor

@padmashris Some weirdness is happening with the workflows. Would you be willing to open another PR directly in this repo (ie., not from a fork)? Please look out for an invitation to collaborate on this repo. Apologies for the hassle!

@padmashris
Copy link
Copy Markdown
Collaborator Author

@avahoffman no worries! yes - just opened up #44

@padmashris padmashris closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants